Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Specify clang exe path in Driver Creation #50

Closed

Conversation

littlewu2508
Copy link

By doing so, TheDriver can get the correct resource dir.

Closes: #48
Reference: #49

By doing so, TheDriver can get the correct resource dir.

Closes: ROCm#48
Reference: ROCm#49
@littlewu2508
Copy link
Author

I believe this is the ultimate fix for #48, and its related issue #49.

https://github.com/RadeonOpenCompute/ROCm-CompilerSupport/blob/846cd67177bcf91dbbb941d525fff99d04364a0b/lib/comgr/src/comgr-compiler.cpp#L1021-L1024

Manually specifying ClangIncludePath is not needed if the driver is created with the correct clang binary path as first argument. In #48 it can be seen that clang driver can add the correct -resource-dir and -internal-isystem itself.

@littlewu2508
Copy link
Author

littlewu2508 commented Nov 18, 2022

With this patch, compile_hip_test_in_process passed on Gentoo, and if I changed clang version from 15.0.1 to 15.0.3 the tests can also pass without recompiling libamd_comgr.so.

@lamb-j
Copy link
Collaborator

lamb-j commented Jan 23, 2024

Merged here ROCm/llvm-project@6eb9d12

Thanks for bringing this up!

@lamb-j lamb-j closed this Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange -resource-dir and -internal-isystem when executing compile_hip_test_in_process
2 participants