proper %||%
#394
Closed
proper %||%
#394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Dec 11, 2023
| @@ -111,10 +111,16 @@ group_generics <- function() { | |||
| Summary = "Summary", | |||
| Complex = "Complex" | |||
| ) | |||
|
|
|||
| ## Not yet: | |||
There was a problem hiding this comment.
Is this related to the %||% change?
There was a problem hiding this comment.
no. The 3rd commit is separate - it says "matrixOps for R >= 4.4 ..".
I did not want to have it added to the the same pull request... github did this against my will ;-\
There was a problem hiding this comment.
It's easiest to keep each PR in a separate branch to avoid that sort of problem. But I can do some surgery on this branch to just include that commit, or probably just re-do it from first principles since it's such a simple change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #392 for one convincing use case why
%||%in S7 should be the same as "everywhere" else