Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't embed external generics #389

Closed
wants to merge 1 commit into from
Closed

Conversation

hadley
Copy link
Member

@hadley hadley commented Nov 27, 2023

Fixes #364

To review this, I think you'll need to read register_method() and convince yourself that when generic isn't a local generic (i.e. from the current package), we'll always return an external generic, which is basically a lazy pointer to the generic.

@hadley
Copy link
Member Author

hadley commented Nov 27, 2023

This approach doesn't work because of the way that S3method() works as detailed in #390.

@hadley hadley closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedding generics when defining methods
1 participant