Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for update_layer #193

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

elipousson
Copy link
Contributor

Checklist

  • update NEWS.md
  • documentation updated with devtools::document()
  • devtools::check() passes locally

Changes

This is a preliminary draft to add support for the updateDefinition end point #127

Issues that this closes

#127

Follow up tasks

Follow-up tasks to be added as this PR develops.

@JosiahParry
Copy link
Collaborator

Can we change this to update_definition() to match the endpoint? The irony is that I manually crafted my first updateDefinition request yesterday lol! The tough part I think for me, is figuring out how to insert /admin into the URL

@JosiahParry
Copy link
Collaborator

@elipousson is this ready for review? I’m going to start prepping for release in the next few days.

@elipousson
Copy link
Contributor Author

@JosiahParry It still needs some work before review! Not sure I'm going to get this in shape for review in advance of your clean-up for CRAN submission but I'll tag you and mark it as ready for review as soon as I have it working.

@JosiahParry
Copy link
Collaborator

No worries! I just wanted to check

@JosiahParry
Copy link
Collaborator

Related #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants