Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tradier intraday history limitations #31

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Martin-Molinero
Copy link
Member

@Martin-Molinero Martin-Molinero commented Mar 12, 2024

Description

Related Issue

Closes #30

Motivation and Context

Fix intraday history requests

Requires Documentation Change

N/A

How Has This Been Tested?

With new an existing tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

- Handle tradier history intraday request limitations, expanding unit
  tests
- Implement tick resolution history requests in chunks, else it blows up
  in tradier api side
@Martin-Molinero Martin-Molinero merged commit d69dd91 into master Mar 12, 2024
1 check failed
@Martin-Molinero Martin-Molinero deleted the bug-30-history-limitations-handling branch March 12, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Historical Data Requests with Hour Resolution
2 participants