Merge branch 'pfas' of https://github.com/QSD-Group/EXPOsan

QSD-Group · Jun 19, 2024 · fa307d6 · fa307d6
2 parents 7eb1e4b + 1fca2c6
commit fa307d6
Show file tree

Hide file tree

Showing 4 changed files with 528 additions and 524 deletions.
diff --git a/exposan/htl/_components.py b/exposan/htl/_components.py
@@ -130,7 +130,7 @@ def create_components(set_thermo=True):
     H2O = Component('H2O', particle_size='Soluble',
                     degradability='Undegradable', organic=False)
 
-    # Intentionally using the molecular formula and MW of water for C/N/P
+    # intentionally using the molecular formula and MW of water for C/N/P
     C = Component('C', search_ID='water', particle_size='Soluble',
                   degradability='Undegradable', organic=False)
 

diff --git a/exposan/htl/analyses/geospatial_analysis.py b/exposan/htl/analyses/geospatial_analysis.py
@@ -2205,15 +2205,15 @@ def add_region(position, xlabel, color):
 
 def add_rectangle(item, color, edgecolor):
     rectangle_fill = Rectangle((SA_results[f'{item}_decarbonization'].quantile(0.05), SA_results[f'{item}_biocrude'].quantile(0.05)),
-                               SA_results[f'{item}_decarbonization'].quantile(0.95) - SA_results[f'{item}_decarbonization'].quantile(0.05),
-                               SA_results[f'{item}_biocrude'].quantile(0.95) - SA_results[f'{item}_biocrude'].quantile(0.05),
-                               fc=color, alpha=0.8)
+                                SA_results[f'{item}_decarbonization'].quantile(0.95) - SA_results[f'{item}_decarbonization'].quantile(0.05),
+                                SA_results[f'{item}_biocrude'].quantile(0.95) - SA_results[f'{item}_biocrude'].quantile(0.05),
+                                fc=color, alpha=0.8)
     ax.add_patch(rectangle_fill)
 
     rectangle_edge = Rectangle((SA_results[f'{item}_decarbonization'].quantile(0.05), SA_results[f'{item}_biocrude'].quantile(0.05)),
-                               SA_results[f'{item}_decarbonization'].quantile(0.95) - SA_results[f'{item}_decarbonization'].quantile(0.05),
-                               SA_results[f'{item}_biocrude'].quantile(0.95) - SA_results[f'{item}_biocrude'].quantile(0.05),
-                               color=edgecolor, lw=3, fc='none', alpha=1)
+                                SA_results[f'{item}_decarbonization'].quantile(0.95) - SA_results[f'{item}_decarbonization'].quantile(0.05),
+                                SA_results[f'{item}_biocrude'].quantile(0.95) - SA_results[f'{item}_biocrude'].quantile(0.05),
+                                color=edgecolor, lw=3, fc='none', alpha=1)
     ax.add_patch(rectangle_edge)
 
 def add_line(item, color):

diff --git a/exposan/htl/geospatial_HTL_systems.py b/exposan/htl/geospatial_HTL_systems.py
@@ -19,6 +19,11 @@
 from biosteam.units import IsenthalpicValve
 from biosteam import settings
 
+# TODO: change all TEA and LCA data to the U.S.-based values
+# if impossible, especially for LCA: use US, then RER, then RoW, then GLO
+# also, remember to use LCA data collected for the 'cutoff' model and 'IPCC' method
+# TODO: confirm IPCC 2013 (no LT) is ok
+
 __all__ = ('create_geospatial_system','biocrude_density')
 
 biocrude_density = 980 # kg/m3, Snowden-Swan et al. 2022 SOT, PNNL