Skip to content

Commit

Permalink
update htl module test results
Browse files Browse the repository at this point in the history
  • Loading branch information
yalinli2 committed Oct 16, 2024
1 parent a727fc2 commit 6d5b6bf
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions tests/test_htl.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,20 @@ def test_htl():
include_check=False,
)

# m1 = htl.create_model('baseline', **kwargs)
# df1 = m1.metrics_at_baseline()
# values1 = [2.979, -9.373, 53.518, 353.492]
# assert_allclose(df1.values, values1, rtol=rtol)
m1 = htl.create_model('baseline', **kwargs)
df1 = m1.metrics_at_baseline()
values1 = [3.218, 5.355, 60.279, 411.336]
assert_allclose(df1.values, values1, rtol=rtol)

# m2 = htl.create_model('no_P', **kwargs)
# df2 = m2.metrics_at_baseline()
# values2 = [3.525, 24.273, 38.064, 221.258]
# assert_allclose(df2.values, values2, rtol=rtol)
m2 = htl.create_model('no_P', **kwargs)
df2 = m2.metrics_at_baseline()
values2 = [3.763, 38.939, 46.453, 293.038]
assert_allclose(df2.values, values2, rtol=rtol)

#!!! Temporarily taken out
m3 = htl.create_model('PSA', **kwargs)
df3 = m3.metrics_at_baseline()
values3 = [2.34, -48.778, 67.086, 469.595]
# assert_allclose(df3.values, values3, rtol=rtol)
values3 = [2.577, -34.192, 69.927, 493.899]
assert_allclose(df3.values, values3, rtol=rtol)


if __name__ == '__main__':
Expand Down

2 comments on commit 6d5b6bf

@yalinli2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiananf2 FYI that all the results changed more than we'd like to see after merging in changes from BioSTEAM/Thermosteam/QSDsan. There are some changes in Thermosteam/BioSTEAM related to equilibrium/distillation, so those could be the reason. Changes in QSDsan are almost exclusively to the dynamic simulation part.

I think pfas branch gives results similar to main.

@jiananf2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me know, @yalinli2. However, I think the changes were not that big (at least within the same orders of magnitude).

Please sign in to comment.