Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie popups #631

Closed
wants to merge 3 commits into from
Closed

Conversation

Amulya-B28
Copy link
Contributor

@Amulya-B28 Amulya-B28 commented Oct 13, 2024

Related Issue

Addition of cookie pop up along with Cookie policies.

Description

This pop up has 3 options to customize, accept or reject cookies and also a link 'Cookie Policy' to read the policies of the website.

Issue no. : #519

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

image
image

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 13, 2024

Deployment failed with the following error:

Resource is limited - try again in 22 minutes (more than 100, code: "api-deployments-free-per-day").

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit 9487a20
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/670c0ee85598b000092a3025
😎 Deploy Preview https://deploy-preview-631--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal
Copy link
Owner

@Amulya-B28 Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!

@Amulya-B28
Copy link
Contributor Author

Amulya-B28 commented Oct 14, 2024

@PriyaGhosal But it is showing there is no conflicts with base branch.

I'll send the screenshot this time when I pull request.

@Amulya-B28 Amulya-B28 deleted the cookie-popups branch October 20, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants