Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Links Setuped Properly and also added navbar css for text … #344

Closed

Conversation

Rahul-AkaVector
Copy link

@Rahul-AkaVector Rahul-AkaVector commented Oct 9, 2024

Related Issue

Fixes: #210

Description

This pull request addresses an issue with navigation links not routing properly after pressing the Sign In button. The problem arose when users attempted to navigate back to the home page from the sign-up page, which resulted in incorrect URL redirection.

The changes implemented ensure that navigation links direct users to the correct sections of the website without appending incorrect hash values to the URL. This improves user experience and maintains the integrity of page navigation.

Motivation and Context:
Users experienced confusion due to incorrect routing, which detracted from the usability of the website. By fixing this issue, we enhance the overall navigation and ensure a smoother user experience.

No additional dependencies are required for this change.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Before:

2024-10-07.19-26-24.mp4

After:

2024-10-09.09-08-21.mp4

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal Please review and let me know the chnages if any ..

Copy link

vercel bot commented Oct 9, 2024

Deployment failed with the following error:

Resource is limited - try again in 47 minutes (more than 100, code: "api-deployments-free-per-day").

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit a79f69e
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/6705fd4248f7da0008cdea9b
😎 Deploy Preview https://deploy-preview-344--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal
Copy link
Owner

@Rahul-AkaVector Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!
image

@PriyaGhosal PriyaGhosal closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞: Navigation Links Not Routing Properly After Pressing Sign In
2 participants