-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Memory Leaks & other minor fixes #15
Conversation
This reverts commit 9fff2a4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the actual functionality changes look great 👍 many thanks for finding this! Review is almost entirely nits for styling reasons (as discussed on Discord this is not your fault, we don't have this posted anywhere) and a couple questions
(some things apply to the whole PR, though I've only commented once)
Co-authored-by: Jonathan Barrow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gorgeous, only one question and that's it
…sed eslint to complain" This reverts commit ab0a6cc.
LGTM! Great work! |
Resolves the memory leak! Leaving this in draft for ~24 hours while I test on prod to ensure it's fixed
Credit to @TortleWortle for initially figuring out the quirk with
.pipe
Changes: