Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding discount from order view page #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arouiadib
Copy link

It still doesn't respect the guidelines.
Just a way of storing things till finding the best way.

@Progi1984 Progi1984 added the Waiting for PM Waiting for PM review label May 22, 2020
@LouiseBonnard
Copy link
Contributor

@arouiadib, thanks a lot for your contribution here! Since the order page has been reworked for version 1.7.7, the discount behavior might have slightly evolved. You can read its specifications here, in the IV-6 section: https://github.com/PrestaShop/prestashop-specs/blob/master/back-office/orders/orders/Order%20Page%20View.md#iv-products-panel.

@MatShir was in charge, can I let you guys check and complete the order page view file with these specifications if need be? I think keeping one file is best in this case. :-)

Comment on lines +23 to +27
1- This is a text input field.

2 -It has a label : "Name".

4- Validation:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1- This is a text input field.
2 -It has a label : "Name".
4- Validation:
1 - This is a text input field.
2 - It has a label : "Name".
4 - Validation:

Comment on lines +34 to +40
1- This is a select input with 3 options.

2 Options are named : "Percent", "Amount" and "Free Shipping" strings.

3- Default option is "Percent".

4- Validation:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1- This is a select input with 3 options.
2 Options are named : "Percent", "Amount" and "Free Shipping" strings.
3- Default option is "Percent".
4- Validation:
1 - This is a select input with 3 options.
2 - Options are named : "Percent", "Amount" and "Free Shipping" strings.
3 - Default option is "Percent".
4 - Validation:

Comment on lines +49 to +51
1- This appears only if selected type is "Percent" or "Amount.

2- This is an input for numeric values.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1- This appears only if selected type is "Percent" or "Amount.
2- This is an input for numeric values.
1 - This appears only if selected type is "Percent" or "Amount.
2 - This is an input for numeric values.

Comment on lines +56 to +61
* a symbol "%" if selected type is "Percent" and "$" if selected type is "Amount".
* a numeric input with up/down arrows.

5 - Validation:
* client-side : this field is required if selected type is "Percent" or "Amount", else, non required.
* server-side : if selected type is "Percent" value should be between 0 and 100, if selected type is "Amount" value should be between 0 and total.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should choose between spaces before list, or without spaces!

@arouiadib
Copy link
Author

arouiadib commented Oct 5, 2020

Hi @LouiseBonnard and @NeOMakinG, thanks a lot for your attention to this trial.
I honestly still don't master specs writing guidelines, and I think things has evolved after this PR :).
I will certainly be back to revise it again and take your points into account.
Thanks again and regards,

@LouiseBonnard
Copy link
Contributor

Sorry that we did not review it earlier, thanks for your thank you, aha! We will also check soon on our end. :-)

@LouiseBonnard LouiseBonnard requested a review from MatShir October 8, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for PM Waiting for PM review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants