Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Docs Setup #61

Merged
merged 48 commits into from
May 3, 2020
Merged

Docs Setup #61

merged 48 commits into from
May 3, 2020

Conversation

justusschock
Copy link
Member

Short Description

Please give a short summary of the main points of this PR

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the RisingTeam
and Reviewer workflows, the only purpose of those is to have a compact view of
the steps)

If there are any questions regarding code style or other conventions check out our
summary.

  • Implementation
  • Docstrings & Typing
  • Check __all__ sections and __init__
  • Unittests (look at the line coverage of your tests, the goal is 100%!)
  • Update notebooks & documentation if necessary
  • Pass all tests
  • Add the checksum of the last implementation commit to the Changelog
  • Populate docs/source/get_started.rst
  • Add tutorials and example for each transform

RisingTeam

RisingTeam workflow
  • Add pull request to project (optionally delete corresponding project note)
  • Assign correct label (if you don't have permission to do this, someone will do it for you.
    Please make sure to communicate the current status of the pr.)
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, NotebookTests, Documentation)
  • Does the implementation follow rising design conventions?
  • Are the tests useful? (!!!) Are additional tests needed?
    Can you think of critical points which should be covered in an additional test?
  • Optional: Check coverage locally / Check tests locally if GPU is necessary to execute

@justusschock justusschock self-assigned this May 1, 2020
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          32       32           
  Lines        1251     1251           
=======================================
  Hits         1224     1224           
  Misses         27       27           
Flag Coverage Δ
#unittests 97.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec0802...aec0802. Read the comment docs.

@justusschock
Copy link
Member Author

If I build this locally, I get issues with not existing file and not registered source parsers.

@mibaumgartner do you have any experience on this? Otherwise I need to investigate tomorrow.

@mibaumgartner
Copy link
Member

No idea (at least without further investigation) 🙈

@justusschock
Copy link
Member Author

justusschock commented May 2, 2020

Currently I got it working without apidoc (with apidoc it looks weird) and the following needs to be done:

  • Add docs for transforms
  • Add docs for ops
  • Add docs for utils
  • add parser for notebooks to integrate tutorials

@mibaumgartner mibaumgartner linked an issue May 3, 2020 that may be closed by this pull request
@justusschock
Copy link
Member Author

justusschock commented May 3, 2020

With this state we can build docs looking like this:
image

However, There are still some missing features:

  • On my local build the collapse on the right does not work as on pytorch docs (no clue why)
  • Integrate notebooks properly
  • For each file: Write introductory section, what this file does. (They will be included automatically)
  • Write a good getting started and Installation Guide

However: I propose to add these things in a follow-up PR, since that way we can get the current docs already running :) Thoughts @mibaumgartner ?

Edit: See #66 and #67

@justusschock justusschock requested review from mibaumgartner and removed request for mibaumgartner May 3, 2020 10:50
@justusschock justusschock added FeatureRequest Request for additional feature ReadyForReview Ready for review labels May 3, 2020
Copy link
Member

@mibaumgartner mibaumgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I think we should start to populate the other features as soon as possible (maybe later today) and use a different PR 👍

@justusschock justusschock merged commit 94b9477 into master May 3, 2020
@justusschock justusschock deleted the docs branch May 3, 2020 11:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FeatureRequest Request for additional feature ReadyForReview Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup docs
2 participants