Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect return value checks #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed incorrect return value checks #20

wants to merge 4 commits into from

Conversation

saltzmanjoelh
Copy link

@RockfordWei RockfordWei self-assigned this Jan 18, 2018
@RockfordWei
Copy link
Contributor

@saltzmanjoelh Thanks for the pull request, however, would you mind check out the latest version of this repo and do another PR to resolve the conflicts, if possible?

@saltzmanjoelh
Copy link
Author

okey dokey, should be good to go @RockfordWei

@RockfordWei
Copy link
Contributor

Sorry FYI, may I also ask a test script for your PR, if possible, something like testTransactions() to prove your valuable work and help the end users to best understand this proposal.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants