Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Port and host information for visualization and interface in environment using docker-compose file #82

Merged
merged 5 commits into from
Apr 11, 2021

Conversation

eshantri
Copy link
Contributor

Fixes #72
In order to test this I tried logging process.env.PORT and process.env.HOST for visualization part and it gives desired output.
For the interface the environment variables are named as REACT_APP_HOST and REACT_APP_PORT.
Screenshot from 2021-03-19 09-47-38
I have also made the above changes in the visualization/index.js so it can access port and host directly from environment.

@codecov-io
Copy link

codecov-io commented Mar 19, 2021

Codecov Report

Merging #82 (812d6ac) into master (16da1c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #82   +/-   ##
======================================
  Coverage    6.53%   6.53%           
======================================
  Files          20      20           
  Lines         597     597           
  Branches       68      68           
======================================
  Hits           39      39           
  Misses        506     506           
  Partials       52      52           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16da1c2...812d6ac. Read the comment docs.

@dlebauer dlebauer requested a review from im-prakher April 8, 2021 05:12
Copy link
Contributor

@im-prakher im-prakher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for good work!

@im-prakher im-prakher merged commit 57a37a8 into PecanProject:master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants