Add FREEZE and THAW methods for serialisation #520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests work with Serial, JSON::MaybeXS, CBOR::XS
and CBOR::Free. (Edit:CBOR::Free
was a false positive - it does not support FREEZE/THAW).I also had a look at testing with some of the YAML modules but they do not support FREEZE/THAW callbacks.
Could probably be squashed into a single commit before merging, thus cleaning up debugging cruft.
Documentation is still needed. It should just comprise a note that serialisers that conform to
Types::Serialiser
are (should be) supported.I'm not sure where to add it, though, as it does not fit under
PDL::IO::Storable
. Perhaps its contents could be shifted to a new PDL::IO::Serialisation or similar which is then loaded by default with the rest of PDL. That might be too large a change, though.