fix IO::Pic problem with older IO::GD installed - #522

PDLPorters · Jan 13, 2025 · 753b40e · 753b40e
1 parent b7980e4
commit 753b40e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -18,6 +18,7 @@
 - Core::dog now scales linearly with length of top dim, not O(n^2) (#421) - thank @djerius for report
 - PDL::IO::Storable now also supports Sereal, JSON::MaybeXS, CBOR::XS (#510,#520) - thanks @shawnlaffan
 - add ParamDesc PP key
+- fix IO::Pic problem with older IO::GD installed (#522) - thanks @shawnlaffan
 
 2.098 2025-01-03
 - fix Windows build problems

diff --git a/lib/PDL/IO/Pic.pm b/lib/PDL/IO/Pic.pm
@@ -86,7 +86,7 @@ sub init_converter_table {
   $Dflags = '';
   %converter = ();
 
-  if (eval {require PDL::IO::GD; 1}) {
+  if (eval {require PDL::IO::GD; PDL::IO::GD->can ('to_rpic') && PDL::IO::GD->can ('write_Jpeg')}) {
     $converter{JPEG} = {referral => {
       put => sub {
         my $pdl = $_[0];

diff --git a/t/storable.t b/t/storable.t
@@ -96,7 +96,7 @@ is_pdl thaw($f2), sequence(long,5), "thawed byte-swapped";
   }
 
   if (!@serialisers) {
-    diag "No serialisation modules installed that support the Types::Serialiser protocol, skipping those tests";
+    note "No serialisation modules installed that support the Types::Serialiser protocol, skipping those tests";
   }
 
   my @ndarrays = (