-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MATE Desktop (fixes #12169) #12174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
.gitignore
Outdated
@@ -117,6 +117,8 @@ oprofile_data/ | |||
|
|||
/out/build/x64-Debug (default) | |||
CMakeSettings.json | |||
CMakeCache.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is because usually build with mkdir build && cmake -B ./build
, but I can cd into ./build
first to avoid the CMake cache files in the top-level directory.
e40dc2f
to
12c0399
Compare
@TheTechnician27 Would you be able to test this on your MATE VM? |
Same test I previously did on the issue report: physically disable kbm and leave the game running. With the 'Inhibit screensaver' option enabled, the screen did not go blank and lock after 6 minutes despite a 3-minute screensaver rule in the DE settings. A control test with the 'Inhibit screensaver' option disabled had the screen go black and lock at the expected time. PR thus appears to work as intended on MATE. 👍 |
This extends the screensaver inhibition function to MATE Desktop,
This extends the screensaver inhibition function to MATE Desktop,
Description of Changes
This PR extends the screensaver inhibition function to MATE Desktop, which fixes #12169