-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GameDB: Atelier Iris (SLUS-21113) fixes #12021
Conversation
Fixes assorted lines around/through sprites when upscaling. Includes confirmed fixes from https://wiki.pcsx2.net/Atelier_Iris:_Eternal_Mana, and matches fixes with games with similar engine from same developer (SLES-54385, SLPM-65985, SLUS-21327)
This reverts commit 5817fab.
GameDB: Atelier Iris (SLUS-21113) fixes for sprites and FMVs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
update to remove trailing space
Validation was failing when using texturePreloading: 2, although it seems to be a valid setting per the GameIndex.md? changed to 1 to avoid failing. Also added full stops to end of comment lines.
Should be enabled by default so no need to enforce.
@JordanTheToaster Thanks for your help and patience while I stumble through this, appreciate you! |
You're good don't worry about it :) |
Description of Changes
Assorted graphics tweaks to fix sprite and FMV issues
Rationale behind Changes
Fixes assorted lines around/through sprites when upscaling. Includes confirmed fixes from https://wiki.pcsx2.net/Atelier_Iris:_Eternal_Mana, and matches fixes with games with similar engine from same developer (SLES-54385, SLPM-65985, SLUS-21327)
When upscaling:
Texture Preloading
is set toFull
orPartial
and HW Renderer used for FMVs, an error is generated that the hash cache has used too much VRAM and has been disabled.Texture Preloading
is set toNone
, small black lines intermittently appear around sprites in-game, particularly if they're movingRound Sprite
atHalf
mitigates this slightly,Full
almost completely erases itSoftwareRendererFMVHack
bypasses both the black lines in FMVs and hash cache errors, and allows forTexture Preloading
to be enabled to prevent other black line/offset issues.Suggested Testing Steps