Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: Atelier Iris (SLUS-21113) fixes #12021

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Conversation

secondsabre
Copy link
Contributor

Description of Changes

Assorted graphics tweaks to fix sprite and FMV issues

Rationale behind Changes

Fixes assorted lines around/through sprites when upscaling. Includes confirmed fixes from https://wiki.pcsx2.net/Atelier_Iris:_Eternal_Mana, and matches fixes with games with similar engine from same developer (SLES-54385, SLPM-65985, SLUS-21327)
When upscaling:

  • If Texture Preloading is set to Full or Partial and HW Renderer used for FMVs, an error is generated that the hash cache has used too much VRAM and has been disabled.
    • If Texture Preloading is set to None, small black lines intermittently appear around sprites in-game, particularly if they're moving
  • Using HW Renderer causes FMVs to have black horizontal lines running through them
    • Using Round Sprite at Half mitigates this slightly, Full almost completely erases it
  • Using SoftwareRendererFMVHack bypasses both the black lines in FMVs and hash cache errors, and allows for Texture Preloading to be enabled to prevent other black line/offset issues.

Suggested Testing Steps

Fixes assorted lines around/through sprites when upscaling.  Includes confirmed fixes from https://wiki.pcsx2.net/Atelier_Iris:_Eternal_Mana, and matches fixes with games with similar engine from same developer (SLES-54385, SLPM-65985, SLUS-21327)
GameDB: Atelier Iris (SLUS-21113) fixes for sprites and FMVs
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@secondsabre
Copy link
Contributor Author

Oh man, forgot to add screens and stuff to show the diffs.

FMV:

HW Renderer
Atelier Iris - Eternal Mana_SLUS-21113_20241119162544

HW Renderer w/ Round Sprite = Full
Atelier Iris - Eternal Mana_SLUS-21113_20241119162605

SW Renderer
(sorry for the change in quality here, realized that built-in screenshot doesn't work when using SW Renderer, so had to do a manual screencap)
zoLjdt5Ngg

Texture Preloading:

Texture Preloading= None
(note the small black lines that flicker around the moving sprites at bottom-center)

texture.cache.none.mp4

Texture Preloading = Full
(small black lines all gone)

texture.cache.full.mp4

Round Sprite:

Round Sprite = Off
Atelier Iris - Eternal Mana_SLUS-21113_20241119163521

Round Sprite = Half
Atelier Iris - Eternal Mana_SLUS-21113_20241119163528

Round Sprite = Full
Atelier Iris - Eternal Mana_SLUS-21113_20241119163534

update to remove trailing space
Validation was failing when using texturePreloading: 2, although it seems to be a valid setting per the GameIndex.md? changed to 1 to avoid failing.

Also added full stops to end of comment lines.
Should be enabled by default so no need to enforce.
@secondsabre
Copy link
Contributor Author

@JordanTheToaster Thanks for your help and patience while I stumble through this, appreciate you!

@JordanTheToaster
Copy link
Member

@JordanTheToaster Thanks for your help and patience while I stumble through this, appreciate you!

You're good don't worry about it :)

@F0bes F0bes merged commit c6c4eaf into PCSX2:master Nov 20, 2024
13 checks passed
SternXD pushed a commit to EmulationCollective/XBSX2 that referenced this pull request Dec 7, 2024
RedPanda4552 pushed a commit to RedPanda4552/pcsx2 that referenced this pull request Dec 20, 2024
SternXD pushed a commit to EmulationCollective/XBSX2 that referenced this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants