DEV9: Move Adapter Detection Hack #11908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMAP_R_EMAC3_TxMODE1_L is unrelated to resetting the adapter
F0bes
reviewed
Oct 13, 2024
TheLastRar
force-pushed
the
DEV9-MoveAdapterResetHack
branch
from
6b95f1f to
62fc66f
Compare
F0bes
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Relocate the Adapter Detection Hack
Relocate call to resetting the network backend (tap/pcap/sockets)
Rationale behind Changes
The Adapter Detection Hack sets
TXEND/RXEND/TXDNVbits in theSPD_R_INTR_STATin order to pass a check during initialisation.PSBBN (see #11746), however, clears
TXEND/RXENDafter we set them, causing it to fail to init.HW tests indicate that both
TXEND(expected) &RXEND(??) get set when processingSMAP_E3_TX_GNP_0.TXDNValso exists, but isn't set duringSMAP_E3_TX_GNP_0(at least in the init phase), so I'm yet unsure where it comes from.Additionally, none of the values written to
SMAP_R_EMAC3_TxMODE1are related to resetting, so move resetting the network backend.The
EMACandPHYare reset during SMAP initialisation, so lets reset the network backend when thePHYis reset.Suggested Testing Steps
Test networking games and homebrew.
Test with sockets, since that would be more sensitive to backend resets.