QT: Clear m_status_verbose_widget text on VM stop #11887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamfretoz
approved these changes
Oct 8, 2024
Mrlinkwii
approved these changes
Oct 8, 2024
F0bes
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Clears the text of
m_status_verbose_widgetRationale behind Changes
When starting emulation, either onVMResumed or onVMPaused is called depending on if Pause on start is set.
The emulator stop prompt will pause the emulator, if you accept, this will backup the previous value of
m_status_verbose_widgettom_last_fps_statusand set the text ofm_status_verbose_widgetto "Paused"When you that start the emulator again, with Pause on start enabled, onVMPaused is called again, which will overwrite the backup text in
m_last_fps_statuswith the value ofm_status_verbose_widget, which was left as "Paused" from the previous run.When you unpause, the text of m_status_verbose_widget is set to the value of m_last_fps_status, which contains "Paused" leading to no visual change.
This PR resets the value of
m_status_verbose_widgetto prevent this.Note that the issue is not visible when "View -> Verbose Status" is enabled, as that replaces the text continuously
Suggested Testing Steps
Enable Pause on start
Start and stop, then start again the emulator