GameDB: some fixes #11508
GameDB: some fixes #11508
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
|
Not sure why you're removing brackets from the types of disc? We've pretty consistently done that through the whole DB, but you removed a couple? Doesn't make sense. I'd rather they were there, tbh, |
Alright. I'll revert it when I have time. |
There was a problem hiding this comment.
Seems like something got messed up, I can't see the diff since there's a lot of changes.
See https://github.com/PCSX2/pcsx2/actions/runs/9825954359/job/27131965803?pr=11508#step:5:1
|
Git is working property I expect |
Enclose the strings by quotation marks. Remove (some) symbols from name-sort that are not read aloud.
Description of Changes
Enclose the strings by quotation marks
Remove (some) symbols from name-sort that are not read aloud
This is for NTSC-J
Rationale behind Changes
More consistent code rules
Sorting should be determined by actual pronounce
Suggested Testing Steps
It is tested on my pc