SPU: Rewrite ADSR/Volume slides #10084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziemas
force-pushed
the
spu-adsrv2
branch
2 times, most recently
from
c435e18 to
15f1638
Compare
Ziemas
force-pushed
the
spu-adsrv2
branch
2 times, most recently
from
ca38791 to
3c1775a
Compare
Ziemas
commented
Oct 13, 2023
What "volume pump" is this even reffering to?
|
Pushed a commit that lowers the volume output, not quite to half like before, but maybe enough to not surprise people. See what you think. |
|
Ironically, 200% was introduced because final volume was too low at times. Also you have a typo voluem in comments. |
kamfretoz
approved these changes
Oct 15, 2023
Mrlinkwii
approved these changes
Oct 15, 2023
JordanTheToaster
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rewrite ADSR and volume slides, also fully moves the SPU over to 16bit volumes getting rid of MulShr32 etc.
Rationale behind Changes
This makes ADSR more accurate, mainly for the exponential decrement mode which was slightly off before.
Suggested Testing Steps
Affects anything and everything.