Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html dark #2276

Closed
wants to merge 8 commits into from
Closed

Conversation

dorryspears
Copy link
Contributor

Referring to issue #2254
@jcamiel A rough draft. I tried using exclusively CSS so I didn't have to implement new functionality to the actual report mechanism. Let me know what you think.

@jcamiel
Copy link
Collaborator

jcamiel commented Jan 4, 2024

Hi @dorryspears

Thanks for the PR, here some things to improv:

  1. You'll need to sign your commits in order to appeal our CI (see CONTRIBUTING.md and https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification). Let me know if you have difficulties to configure your signature, I can help you.

  2. In the CSS changes, just overrides the color changes :

Instead of:

@media (prefers-color-scheme: dark) {
    body {
        background-color: #121212;
        color: #f5f5f5;
        font-family: "Helvetica Neue", Arial, sans-serif;
        font-size: 1.125rem;
        line-height: 1.4;
    }

    .container {
        max-width: 1200px;
        width: 100%;
        margin-left: auto;
        margin-right: auto;
    }

    h2 {
        color: #ff62b0;
        font-size: 2.5rem;
    }
etc...

You can do this:

@media (prefers-color-scheme: dark) {
    body {
        background-color: #121212;
        color: #f5f5f5;
    }

    h2 {
        color: #ff62b0;
    }
etc...

Ideally, you could merge all your commits in just one commits

  1. Use the same color as Dark mode for https://hurl.dev. You can see the colour scheme here:

https://github.com/Orange-OpenSource/hurl-dev/blob/master/sites/hurl.dev/_sass/_colors.scss

h2 color in Dark mode should be #ff0288 for instance.

Thanks !!

@dorryspears dorryspears closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants