Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error description for some parse error #2222

Merged
merged 8 commits into from
Dec 8, 2023
Merged

Better error description for some parse error #2222

merged 8 commits into from
Dec 8, 2023

Conversation

jcamiel
Copy link
Collaborator

@jcamiel jcamiel commented Dec 3, 2023

  • Replace else arm with all variant arms.
  • Better XML parsing error description.
  • Better multi-part form data file content-type parsing error description.

@jcamiel jcamiel self-assigned this Dec 3, 2023
@jcamiel jcamiel linked an issue Dec 3, 2023 that may be closed by this pull request
Some parse error use debug description insted of a proper error string #2187
Closed
@jcamiel jcamiel force-pushed the 2187-some-parse-error-use-debug-description-insted-of-a-proper-error-string branch 6 times, most recently from df58c19 to 415afdc Compare December 6, 2023 14:55
@jcamiel jcamiel force-pushed the 2187-some-parse-error-use-debug-description-insted-of-a-proper-error-string branch from e932eec to ccd6b37 Compare December 8, 2023 13:42
@jcamiel jcamiel marked this pull request as ready for review December 8, 2023 13:43
@jcamiel
Copy link
Collaborator Author

jcamiel commented Dec 8, 2023

/accept

@hurl-bot
Copy link
Collaborator

hurl-bot commented Dec 8, 2023

🕗 /accept is running, please wait for completion.

@jcamiel jcamiel force-pushed the 2187-some-parse-error-use-debug-description-insted-of-a-proper-error-string branch from ccd6b37 to 77f2984 Compare December 8, 2023 13:50
@jcamiel jcamiel force-pushed the 2187-some-parse-error-use-debug-description-insted-of-a-proper-error-string branch 2 times, most recently from e501849 to 3b537d8 Compare December 8, 2023 14:17
@jcamiel jcamiel force-pushed the 2187-some-parse-error-use-debug-description-insted-of-a-proper-error-string branch from 3b537d8 to 6498bd3 Compare December 8, 2023 14:31
@hurl-bot
Copy link
Collaborator

hurl-bot commented Dec 8, 2023

✅ Pull request merged and closed by jcamiel with fast forward merge..

# List of commits merged from Orange-OpenSource/hurl/2187-some-parse-error-use-debug-description-insted-of-a-proper-error-string branch into Orange-OpenSource/hurl/master branch:

  • 6498bd3 Delete not reachable error.
  • a7807cf Better unicode parsing error description.
  • 95528ba Better option error description.
  • 0c92430 Better hexadecimal digit parsing error description.
  • 0185c0b Remove specific end-of-file for regex error.
  • bdf0d05 Better multi-part form data file content-type parsing error description.
  • e7e7faf Better XML parsing error description.
  • 0c7f287 Replace else arm with all variant arms.

@hurl-bot hurl-bot merged commit 6498bd3 into master Dec 8, 2023
19 checks passed
@hurl-bot hurl-bot deleted the 2187-some-parse-error-use-debug-description-insted-of-a-proper-error-string branch December 8, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcamiel jcamiel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some parse error use debug description insted of a proper error string
2 participants
@jcamiel @hurl-bot