Delete xmltree/indexmap dependencies #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to xmltree re-exposing an older version of indexmap, we couldnt' upgrade to the latest version of indemap. xmltree is a tree in-memory representation of an XML document that we use for JUnit export. As xmltree is a thin layer above xml-rs, we re-implement a thin tree in-memory XML document using xml-rs directly and remove xmltree/indexmap dependency.
jcamiel
changed the title
|
/accept |
|
🕗 /accept is running, please wait for completion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to xmltree re-exposing an older version of indexmap, we couldnt' upgrade to the latest version of indemap.
xmltree provides an in-memory tree representation of an XML document that we use for JUnit report. As xmltree is a thin layer above xml-rs, we re-implement a tree in-memory XML document using xml-rs directly and remove xmltree/indexmap dependencies.