Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAP reports can't be appended if there are failed tests #2095

Merged
merged 2 commits into from
Oct 27, 2023
Merged

TAP reports can't be appended if there are failed tests #2095

merged 2 commits into from
Oct 27, 2023

Conversation

msinton
Copy link
Contributor

@msinton msinton commented Oct 26, 2023 •
edited
Loading

When using flag --report-tap
When reusing a file that contains failures, parsing fails because the file contains:
"not ok"
when expected to be
"nok"

Therefore, it is not possible to generate a list of failures with this reporting mechanism

@jcamiel
Copy link
Collaborator

jcamiel commented Oct 27, 2023

Hi @msinton thanks for the PR!
Good catch for this bug, but the solution proposed has to be slightly changed. I've push modifications to your branch, plus I've modified some integration tests to add some failed tests in report generation. I will also create an issue to track this PR!

@jcamiel jcamiel changed the title Report failures with nok TAP reports can't be appended if there are failed tests Oct 27, 2023
@jcamiel jcamiel linked an issue Oct 27, 2023 that may be closed by this pull request
TAP reports can't be appended if there are failed tests #2099
Closed
@jcamiel jcamiel force-pushed the patch-1 branch 8 times, most recently from 23a1eb1 to 3435a39 Compare October 27, 2023 12:27
msinton
msinton commented Oct 27, 2023
View reviewed changes
integration/tests_ok/tap.ps1 Outdated Show resolved Hide resolved
msinton
msinton commented Oct 27, 2023
View reviewed changes
integration/tests_ok/tap.sh Outdated Show resolved Hide resolved
@msinton
Copy link
Contributor Author

msinton commented Oct 27, 2023

Thank you @jcamiel
I've found a few typos, otherwise this looks good to me 👍

@jcamiel jcamiel self-assigned this Oct 27, 2023
@jcamiel
Copy link
Collaborator

jcamiel commented Oct 27, 2023

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

✅ Pull request merged and closed by jcamiel with fast forward merge..

# List of commits merged from msinton/hurl/patch-1 branch into Orange-OpenSource/hurl/master branch:

  • 0757d5e Add failed test in HTML/JUnit/TAP reports
  • 20982f4 Report failures with nok

@hurl-bot hurl-bot merged commit 0757d5e into Orange-OpenSource:master Oct 27, 2023
18 checks passed
@jcamiel
Copy link
Collaborator

jcamiel commented Oct 27, 2023

Thanks for the PR @msinton the fix have been merged on master.

@msinton msinton deleted the patch-1 branch October 27, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcamiel jcamiel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TAP reports can't be appended if there are failed tests
3 participants
@msinton @jcamiel @hurl-bot