Skip to content

Commit

Permalink
Revert "Set persist-credentials to false on checkout action"
Browse files Browse the repository at this point in the history
  • Loading branch information
lepapareil committed Jan 10, 2025
1 parent 2be16ae commit 293fa2b
Show file tree
Hide file tree
Showing 11 changed files with 1 addition and 42 deletions.
1 change: 0 additions & 1 deletion .github/workflows/accept-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ env.BASE_REF }}
token: ${{ secrets.HURL_BOT_TOKEN }}
fetch-depth: 0
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/auto-close-inactive-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ jobs:
steps:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
- name: Auto close inactive PR
run: .github/workflows/bin/auto-close-inactive-pr.sh --github-project-path "${REPO}" --github-token "${GITHUB_TOKEN}" --max-days-of-inactivity 15

1 change: 0 additions & 1 deletion .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}

- name: Shellcheck
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ jobs:
steps:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false

- name: Install Prerequisites
run: bin/install_prerequisites_ubuntu.sh
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/extra-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
fetch-depth: 1
ref: ${{ github.event.inputs.set-release-version }}
- name: Check if branch is a published release
Expand All @@ -53,7 +52,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
fetch-depth: 1
ref: ${{ github.event.inputs.set-release-version }}
- name: Push to chocolatey
Expand All @@ -71,7 +69,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
fetch-depth: 1
ref: ${{ github.event.inputs.set-release-version }}
- name: Push to winget
Expand Down
12 changes: 0 additions & 12 deletions .github/workflows/package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install prerequisites
run: bin/install_prerequisites_ubuntu.sh
Expand Down Expand Up @@ -65,7 +64,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Set up QEMU
uses: docker/[email protected]
Expand Down Expand Up @@ -115,7 +113,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Retrieve release-generic-linux-x64-artifacts
uses: actions/[email protected]
Expand Down Expand Up @@ -169,7 +166,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Retrieve release-generic-linux-x64-artifacts
uses: actions/[email protected]
Expand Down Expand Up @@ -221,7 +217,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Retrieve release-generic-linux-x64-artifacts
uses: actions/[email protected]
Expand Down Expand Up @@ -273,7 +268,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Retrieve release-generic-linux-x64-artifacts
uses: actions/[email protected]
Expand Down Expand Up @@ -327,7 +321,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Set up Docker Buildx
uses: docker/[email protected]
Expand Down Expand Up @@ -399,7 +392,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install Prerequisites
run: bin/install_prerequisites_ubuntu.sh
Expand Down Expand Up @@ -451,7 +443,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install Prerequisites
run: |
Expand Down Expand Up @@ -501,7 +492,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install Prerequisites
run: |
Expand Down Expand Up @@ -557,7 +547,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install Rust
run: |
Expand Down Expand Up @@ -617,7 +606,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- uses: actions/[email protected]
with:
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ jobs:
steps:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false

- name: Check release pull request existence
id: check-release-pull-request-existence
Expand Down Expand Up @@ -172,8 +170,6 @@ jobs:
- name: Checkout repository
if: github.ref_name == 'master'
uses: actions/[email protected]
with:
persist-credentials: false

- name: Create release branch
if: github.ref_name == 'master'
Expand All @@ -191,7 +187,6 @@ jobs:
- name: Checkout new release branch
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ needs.set-context.outputs.release_branch }}

- name: Check CHANGELOG
Expand Down Expand Up @@ -298,7 +293,6 @@ jobs:
- name: Checkout new release branch
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ needs.set-context.outputs.release_branch }}

- name: Init git bot context
Expand Down
13 changes: 1 addition & 12 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install Prerequisites
run: bin/install_prerequisites_ubuntu.sh
Expand Down Expand Up @@ -55,7 +54,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install Rust
run: bin/install_rust.sh
Expand All @@ -77,7 +75,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install Prerequisites
run: bin/install_prerequisites_ubuntu.sh
Expand Down Expand Up @@ -122,7 +119,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install Prerequisites
run: bin/install_prerequisites_ubuntu.sh
Expand Down Expand Up @@ -164,7 +160,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Build, Test units and Integration tests
uses: addnab/docker-run-action@v3
Expand Down Expand Up @@ -206,7 +201,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Build, Test units and Integration tests
uses: addnab/docker-run-action@v3
Expand Down Expand Up @@ -255,7 +249,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Build, Test units and Integration tests
uses: addnab/docker-run-action@v3
Expand Down Expand Up @@ -306,7 +299,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install Prerequisites
run: |
Expand Down Expand Up @@ -355,7 +347,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install Prerequisites
run: |
Expand Down Expand Up @@ -407,7 +398,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
- name: Install Rust
run: |
Expand Down Expand Up @@ -449,8 +439,7 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}
ref: ${{ inputs.branch }}
- name: Setup wsl Ubuntu
uses: Vampire/[email protected]
with:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/update-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: master
token: ${{ secrets.HURL_BOT_TOKEN }}

Expand Down
1 change: 0 additions & 1 deletion .github/workflows/update-branch-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: ${{ inputs.branch }}

- name: Init bot branch name
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/update-crates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
- name: Checkout repository
uses: actions/[email protected]
with:
persist-credentials: false
ref: master

- name: Crates update
Expand Down

0 comments on commit 293fa2b

Please sign in to comment.