Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check to create dist folder if its does not exists already and Customising name of NSIS exe package #133

Closed
wants to merge 0 commits into from
Closed

Added check to create dist folder if its does not exists already and Customising name of NSIS exe package #133

wants to merge 0 commits into from

Conversation

shkpk
Copy link
Contributor

@shkpk shkpk commented Oct 1, 2020

This PR is to fix issue #132

@shkpk shkpk changed the title Added check to create dist folder if its does not exists already Added check to create dist folder if its does not exists already and Customising name of NSIS exe package Oct 1, 2020
@mattock
Copy link
Member

mattock commented Oct 6, 2020

@shkpk afaics this look good. Did you test building an MSM with this?

@shkpk
Copy link
Contributor Author

shkpk commented Oct 6, 2020

@shkpk afaics this look good. Did you test building an MSM with this?

@mattock this change is specifically targeting NSIS build. There is no code change effecting MSM.

@shkpk
Copy link
Contributor Author

shkpk commented Oct 7, 2020

@shkpk afaics this look good. Did you test building an MSM with this?

@mattock this change is specifically targeting NSIS build. There is no code change effecting MSM.

I updated msm packages to use PRODUCT_PACKAGE_NAME as NSIS installer for customized name of exe/msm

@lstipakov
Copy link
Member

I compile-tested MSM part and it looks fine. Could you rebase your PR on top of master and squash to the reasonable amount of commits?

@shkpk
Copy link
Contributor Author

shkpk commented Oct 8, 2020

I compile-tested MSM part and it looks fine. Could you rebase your PR on top of master and squash to the reasonable amount of commits?

Done 👍

@mattock
Copy link
Member

mattock commented Oct 12, 2020

There are still several merge commits and two commits that unnecessary share the same commit message. I would just do

git reset --soft <last-upstream-commit-id>

Then add/commit the modified files from scratch.

@shkpk shkpk closed this Oct 19, 2020
@shkpk
Copy link
Contributor Author

shkpk commented Oct 19, 2020

@mattock Opened new PR #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shkpk @mattock @lstipakov