Add a new inspector for the component. #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need Roassal
|
There is currently a bug, the link does not really make sens right now. |
|
Thanks @Nyan11! Is it working with the default Roassal embedded into a Pharo image? |
|
I think you need the full version of roassal. We should make a variant in the baseline. |
|
Can you add tests to check essentials? |
The link where only checking if the component had the same interfaces, now it also check for the component name
|
Now layout look like this: After replacing the component: |
|
I have to move the class in a new package and create the baseline variant. |
|
Are you sure that you are need a different roassal than the version in Pharo? |
|
I just check, we do not need the full roassal version to be laoded in order to work. |
|
It can be merged |
|
Nice! I will review :-) |
labordep
reviewed
Dec 6, 2024
|
@LabordePierre @labordep Ready to merge |
LabordePierre
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need Roassal to work.
You can clic on a component or a service and have it open in the second panel
To launch start an example and click on world menu > Molecule > inspect running component