Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #170: Add announcements for component life-cycle + unit tests. #177

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Fix #170: Add announcements for component life-cycle + unit tests. #177

merged 2 commits into from
Jun 25, 2024

Conversation

labordep
Copy link
Member

@labordep labordep commented Apr 7, 2024

Minor cleanup.

@labordep labordep added the enhancement New feature or request label Apr 7, 2024
@labordep labordep self-assigned this Apr 7, 2024
@labordep labordep requested a review from ELePors April 7, 2024 17:48
@ELePors
Copy link
Member

ELePors commented Apr 10, 2024

We should add a cleanup process to reset all announcement registered about components.

ELePors
ELePors requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@ELePors ELePors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a cleanup process for announcement

src/Molecule-Tests/MolComponentAnnouncementTest.class.st Show resolved Hide resolved
@labordep
Copy link
Member Author

@ELePors Can you send your code into this branch?

@labordep
Copy link
Member Author

@ELePors Can you send your code into this branch?

Up :)

@labordep
Copy link
Member Author

@ELePors, @Eliott-Guevel is waiting for your commit. Thanks.

@labordep
Copy link
Member Author

👍

@labordep labordep assigned ELePors and unassigned labordep Jun 25, 2024
labordep
labordep commented Jun 25, 2024
View reviewed changes
Copy link
Member Author

@labordep labordep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@labordep labordep merged commit 96c46d6 into main Jun 25, 2024
12 of 18 checks passed
@labordep labordep deleted the 170-Add-announcers-to-know-when-a-Molecule-Component-is-started-and-stopped branch June 25, 2024 14:27
@labordep labordep mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ELePors ELePors ELePors requested changes

Assignees

@ELePors ELePors

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labordep @ELePors