-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additive radar-CML merging with IDW and with Krignig, plus example data #3
Conversation
- creates 5min aggregated CML, rain gauge and radar data for the openmerge dataset src/mergeplg/merge.py: - first implementation of merging src/mergeplg/interpolator.py and src/mergeplg/idw.py: - IDW interpolator functions from python
- changed 'import mergeplg' to 'import mergeplg.merge' src/mergeplg/idw.py: - replaced np.NaN with np.nan src/mergeplg/interpolator.py and src/mergeplg/merge.py - changed idw import to relative import
- Move estimate_kriging_parameters to notebook. - Write docstrings to functions W.I.P.
… from nox without doing gid add for every step
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 2
Lines ? 89
Branches ? 0
========================================
Hits ? 89
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
A lot of green check marks now! 🎉 Thanks @eoydvin. I will look into the details next week. |
You can remove the |
I also have some KED prototype files now, but then the tests will not run anymore. Should we just keep it like this for now then? |
Yes. Let's keep this PR focused on what you already have and add KED in another PR. I will have a look this week. |
Sorry for the long delay 🙈. I now finally had a quick look at the code and notebook. Looks really good 👏 👏 👏 . Of course, we will have to see/discuss how we define a common higher-level interface for the different functions. But this is a very good starting point. I am merging this now. Once I have my PR #6 ready or merged we should start the discussion about aligning the code, i.e. finding the mentioned common "interface". |
This data was produced and added in mergeplg via OpenSenseAction/mergeplg#3
This PR implements parts of what is discussed in #2
src/mergeplg/merge.py:
src/mergeplg/interpolator.py and src/mergeplg/idw.py: