build system tweaks #1275
Merged
build system tweaks #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
agalasso
commented
Dec 31, 2024
agalasso
commented
- use WXWIN environment variable directly so callers do not need to set wxWdgets_PREFIX_DIRECTORY when invoking cmake
- Windows: use the Visual Studio 17 generator by default (so callers do not need to specify it)
- Remove INDI as an explicit dependency of the phd2 executable CMake target. This will speed up the incremental edit-compile-test cycle a little bit, but developers will have to build INDI once before building the phd2 target specifically. In Visual Studio this means building the whole solution once before building the phd2 project.
- use WXWIN environment variable directly so callers do not need to set wxWdgets_PREFIX_DIRECTORY when invoking cmake - Windows: use the Visual Studio 17 generator by default (so callers do not need to specify it) - Remove INDI as an explicit dependency of the phd2 executable CMake target. This will speed up the incremental edit-compile-test cycle a little bit, but developers will have to build INDI once before building the phd2 target specifically. In Visual Studio this means building the whole solution once before building the phd2 project.
bwdev01
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.