Enable sfo tests and create the adfs feature #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
feature/behat-adfs-coverage
branch
2 times, most recently
from
e16356e to
5be24dd
Compare
Tests where added to the ADFS and SFO test suites. Covering successfull and failing GSSP and Built in (yubikey) authtentications
MKodde
force-pushed
the
feature/behat-adfs-coverage
branch
from
5be24dd to
80e3103
Compare
|
@pmeulen Would you review the new test cases? In short I added SFO and ADFS tests with a Yubikey and a demo-gssp. Both types of authentication are tested in happy flow, and a cancellation is tested. Do you have suggestions for additional test coverage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the devssp SP.php is capable of doing SFO & ADFS emulation again. This is a great time to enable the
sfo.featureand add a newadfs.feature.