Skip to content

Commit

Permalink
Behat Docker fixes
Browse files Browse the repository at this point in the history
- No longer create /var/www/html/public: This is done upstream
- Use the latest versions of GH actions
- No longer build the image at every push.
  • Loading branch information
quartje authored and MKodde committed Feb 20, 2024
1 parent 384efca commit 24d7a54
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 10 deletions.
15 changes: 6 additions & 9 deletions .github/workflows/build-push-test-docker-image.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: build-push-test-docker-image

on:
push:
branches:
- feature/behat_tests
workflow_dispatch:

jobs:
Expand All @@ -13,16 +10,16 @@ jobs:
packages: write
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up QEMU
uses: docker/setup-qemu-action@v2
uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3

- name: Login to GitHub Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
Expand All @@ -43,7 +40,7 @@ jobs:
type=raw,suffix=,value=test
- name: Build and push the TEST image
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: .
file: stepup/tests/Dockerfile
Expand Down
1 change: 0 additions & 1 deletion stepup/tests/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ FROM ghcr.io/openconext/openconext-basecontainers/php72-apache2-node16-composer2
RUN apt-get update && \
apt-get install -y docker.io mariadb-client
WORKDIR /config/tests/behat
RUN mkdir /var/www/html/public

0 comments on commit 24d7a54

Please sign in to comment.