Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] rename files on download to avoid UUID as names (#9634) #9618

Open
wants to merge 1 commit into
base: release/6.5.0
Choose a base branch
from

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented Jan 16, 2025

When downloading a file, we use direct links to the storage.
Some files are generated and named as UUID, not very easy to use once downloaded.

In this PR, I add a quick workaround to be able to override the filename at download time, and use it for exclusion lists and support packages.

Note that a proper implementation would be to do this backend side, so that we are able to fetch files with proper naming, according to data / business logic. This is significantly more work than this workaround.

closes #9634

Issue #9635 addresses a long-term solution, for another PR.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.56%. Comparing base (34871d2) to head (209789f).
Report is 4 commits behind head on release/6.5.0.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/6.5.0    #9618   +/-   ##
==============================================
  Coverage          64.56%   64.56%           
==============================================
  Files                638      638           
  Lines              61833    61833           
  Branches            6858     6858           
==============================================
  Hits               39923    39923           
  Misses             21910    21910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg changed the title [frontend] rename files on download to avoid UUID as names [frontend] rename files on download to avoid UUID as names (#9634) Jan 17, 2025
@labo-flg labo-flg marked this pull request as ready for review January 17, 2025 14:14
@labo-flg labo-flg force-pushed the release/6.5.0 branch 5 times, most recently from 9535c45 to 8574b42 Compare January 17, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant