Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] spacing on entity's form (#9567) #9608

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

ValentinBouzinFiligran
Copy link
Member

Proposed changes

  • spacing 20 between fields in entity's form

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.32%. Comparing base (e32b9ec) to head (bd1a481).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9608      +/-   ##
==========================================
+ Coverage   65.22%   66.32%   +1.10%     
==========================================
  Files         630      630              
  Lines       60201    60553     +352     
  Branches     6741     7539     +798     
==========================================
+ Hits        39264    40160     +896     
+ Misses      20937    20393     -544     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec JeremyCloarec self-requested a review January 16, 2025 09:48
@JeremyCloarec
Copy link
Contributor

It works for the Create an entity form, but there is an unwanted side effect: the margin top is also applied to the Creation form of the entity:
With the fix:
image
On testing:
image

@SarahBocognano
Copy link
Member

Approved even if need to change the spacing on top of the form like Jeremy said

@ValentinBouzinFiligran ValentinBouzinFiligran merged commit 40a8cdd into master Jan 17, 2025
9 checks passed
@ValentinBouzinFiligran ValentinBouzinFiligran deleted the issue/9567 branch January 17, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants