Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix capability check on feeds (#9573) #9574

Merged
merged 4 commits into from
Jan 14, 2025
Merged

[backend] fix capability check on feeds (#9573) #9574

merged 4 commits into from
Jan 14, 2025

Conversation

lndrtrbn
Copy link
Member

Proposed changes

  • Fix capability checks

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@lndrtrbn lndrtrbn added the filigran team use to identify PR from the Filigran team label Jan 13, 2025
@lndrtrbn lndrtrbn self-assigned this Jan 13, 2025
@SouadHadjiat
Copy link
Member

just need to fix tests @lndrtrbn (adding capa to editor user changes the counters, since it adds an internal relationship between role & capa)

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.32%. Comparing base (b15b97c) to head (6f8d615).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...cti-platform/opencti-graphql/src/http/httpTaxii.js 0.00% 3 Missing ⚠️
...atform/opencti-graphql/src/http/httpRollingFeed.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9574      +/-   ##
==========================================
+ Coverage   65.17%   65.32%   +0.15%     
==========================================
  Files         630      630              
  Lines       60172    60202      +30     
  Branches     6725     6788      +63     
==========================================
+ Hits        39217    39328     +111     
+ Misses      20955    20874      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn merged commit f7549fc into master Jan 14, 2025
9 checks passed
@lndrtrbn lndrtrbn deleted the issue/9573 branch January 14, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access CSV and TAXII feed if user has only capability to manage feeds
2 participants