-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend/backend] Specify arch and platform when creating injects for OpenBAS (#8820) #9250
base: master
Are you sure you want to change the base?
Conversation
3f41956
to
7ee2dc3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9250 +/- ##
==========================================
+ Coverage 65.17% 65.24% +0.06%
==========================================
Files 630 630
Lines 60172 60454 +282
Branches 6725 6881 +156
==========================================
+ Hits 39217 39443 +226
- Misses 20955 21011 +56 ☔ View full report in Codecov by Sentry. |
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
1761075
to
f4abc2e
Compare
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
10fafec
to
d8dcb3a
Compare
6d8119d
to
14d43ce
Compare
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
dae6e27
to
868e779
Compare
ccf34f2
to
09f4393
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When OBAS has error the success message is displayed in UI ("Le scénario a été correctement généré dans votre plateforme OpenBAS.") would be better to say that something has not worked IMO. Maybe better to throw exception.
Proposed changes
Docs
Notion with uses cases to test: https://www.notion.so/filigran/Test-OCTI-OBAS-1548fce17f2a8060adf6e3e99740452b
Notion with Api update: https://www.notion.so/filigran/Integration-OCTI-OBAS-1598fce17f2a800a9cddea83b6e6f39f
PR Doc OBAS: [doc] Update opencti generating scenario doc OpenBAS-Platform/docs#72
Related issues
Checklist
Further comments