Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Misc Hint : Market 10 Big Poes #2318

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Oct 22, 2024

Adds a new Misc Hint to the list, that changes the textbox of Ghost Hunter to display his reward for bringing him Big Poes:

poe_hint

For the implementation I had to special case build_misc_location_hints because this textbox was already changed by rando to display the number of big poes needed. So this change is now done there rather than in Patches.py, even of course if the misc hint is off, to keep the current behaviour.

@fenhl fenhl added Type: Enhancement New feature or request Status: Needs Review Someone should be looking at it Component: Hints related to how we help the player Status: Under Consideration Developers are considering whether to accept or decline the feature described Component: Patching Affects the patching of the ROM labels Oct 22, 2024
data/Glitched World/Overworld.json Outdated Show resolved Hide resolved
data/World/Overworld.json Outdated Show resolved Hide resolved
@fenhl fenhl added the Status: Waiting for Author Changes or response requested label Oct 23, 2024
@fenhl fenhl removed Status: Waiting for Author Changes or response requested Status: Needs Review Someone should be looking at it labels Oct 23, 2024
@cjohnson57 cjohnson57 removed the Status: Under Consideration Developers are considering whether to accept or decline the feature described label Dec 5, 2024
@fenhl fenhl added this to the next milestone Dec 6, 2024
@fenhl fenhl merged commit 963858a into OoTRandomizer:Dev Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Hints related to how we help the player Component: Patching Affects the patching of the ROM Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants