Magic Meter Item: Still Bar But Now Softly Shaded #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still much prefer the rainbow smoke magic, but this is definitely an improvement. I'd rather the magic model be a cosmetic setting if the community is so divided on which one to use. |
fenhl
added
Type: Enhancement
fenhl
reviewed
Oct 23, 2024
fenhl
approved these changes
Oct 31, 2024
|
I'll go ahead and merge this since it's already here and people like it more, but as a general FYI Maple is currently working on a completely different model that will hopefully be a better replacement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per feedback, the shine was too intense. Thanks the help of flag and RealRob, I've now got a Fast64 pipeline that allows for opacity changes between zero and one. New proposed model:
I'm putting this as a draft because folks were talking about making this model a setting instead and I don't know how to make a setting.