forked from AmazingAmpharos/OoT-Randomizer
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors reported by mypy #2193
Draft
fenhl
wants to merge
18
commits into
OoTRandomizer:Dev
Choose a base branch
from
fenhl:mypy
base: Dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+43,451
−40,011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenhl
added
Status: Needs Review
Someone should be looking at it
Status: Needs Testing
Probably should be tested
Type: Maintenance
Code style, infrastructure, updating dependencies
labels
Mar 21, 2024
fenhl
force-pushed
the
mypy
branch
3 times, most recently
from
March 27, 2024 09:00
0e909bf
to
98cb72d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Needs Review
Someone should be looking at it
Status: Needs Testing
Probably should be tested
Type: Bug
Something isn't working
Type: Maintenance
Code style, infrastructure, updating dependencies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #2177, this reduces the number of errors reported by
mypy ./OoTRandomizer.py
(mypy 1.13.0) from 1202 to 167 while also making some drive-by bug and code style fixes.