Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PV panel equipment definition #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −1
Open

Add PV panel equipment definition #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7422db8
Added simple representation of a photovoltaic panel.
DougPlumley Nov 16, 2023
54ce51b
Restored original formatting.
DougPlumley Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion data/attr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,4 +163,15 @@ ratedVoltage:
identification:
- kind: Number
unit_type: electric_potential


ratedWattage:
name: Rated Wattage
domain: electrical
haystack:
type:
- rated
- wattage
- attr
identification:
- kind: Number
unit_type: electric_wattage
Comment on lines +167 to +177
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ratedWattage:
name: Rated Wattage
domain: electrical
haystack:
type:
- rated
- wattage
- attr
identification:
- kind: Number
unit_type: electric_wattage
ratedPower:
name: Rated Power
domain: electrical
haystack:
type:
- rated
- power
- attr
identification:
- kind: Number
unit_type: power

This is a great attribute to add as it comes up in many contexts beyond just PV panels. I suggest using the term "Power" to describe this attribute rather than wattage as it may have different units in different contexts. Additionally I would use the power tag since that's an existing tag in OAP. Lastly, the unit_type should align with the units types in field.units.yaml so I would use power as the unit_type here.

8 changes: 8 additions & 0 deletions data/electrical/equip.electrical.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,3 +545,11 @@ XFMR:
- equipRef
reference_optional:
- spaceRef
PVP:
name: Photovoltaic Panel
description: A collection of photovoltaic cells arranged into a panel to produce electrical energy.
brick_ontology: Photovoltaic Panel
attributes:
- ratedVoltage
- ratedCurrent
- ratedWattage
Comment on lines +548 to +555
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PVP:
name: Photovoltaic Panel
description: A collection of photovoltaic cells arranged into a panel to produce electrical energy.
brick_ontology: Photovoltaic Panel
attributes:
- ratedVoltage
- ratedCurrent
- ratedWattage
PVP:
name: Photovoltaic Panel
description: A collection of photovoltaic cells arranged into a panel to produce electrical energy.
brick_ontology: Photovoltaic Panel
attributes:
- ratedVoltage
- ratedCurrent
- ratedPower
haystack:
type:
- equip
- photovoltaic
- panel

In addition to having a unique OAP code as the key for each entity, we typically add a unique set of haystack tags to each entity. I suggest adding equip, photovoltaic (new tag that we are planning to use for PV-related entities) and panel.