-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tsystems 211 upgrade spring boot #707
base: develop
Are you sure you want to change the base?
Conversation
…d not keycloak authentication token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @tkuzynow, added some comments, and for now I did not had a look at the tests, is that ok?
<phase>process-sources</phase> | ||
<configuration> | ||
<target> | ||
<delete file="${project.build.directory}/generated-sources/de/caritas/cob/userservice/api/adapters/web/dto/GroupSessionConsultantDTO.java"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh for what is this needed?
|
||
var query = | ||
AdminFilterQueryBuilder.getInstance(queryBuilder).onAdminFilter(adminFilter).buildQuery(); | ||
// Build the search query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove all of the comments, because they are clear or not correct (not only the query is build for example)
import org.springframework.data.annotation.CreatedDate; | ||
import org.springframework.data.annotation.LastModifiedDate; | ||
import org.springframework.data.jpa.domain.support.AuditingEntityListener; | ||
|
||
/** Represents a user */ | ||
@Entity | ||
@Table(name = "user") | ||
@Table(name = "`user`") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really?
@@ -156,7 +153,7 @@ public int hashCode() { | |||
|
|||
@JsonIgnore | |||
@Transient | |||
public Dialect getDialect() { | |||
return isLanguageFormal() ? Dialect.FORMAL : Dialect.INFORMAL; | |||
public de.caritas.cob.userservice.mailservice.generated.web.model.Dialect getDialect() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason for all those full-qualified paths? there are a lot of places where I did not asked, but here it's unclear for my why.
@@ -0,0 +1,10 @@ | |||
@FilterDefs({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh this is ähm nice ;) so you can define that in the package-info that it matches for all classes inside?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what replaces that?
Quality Gate passedIssues Measures |
Fixes #
Proposed Changes