Warper: Fixes related to mode resampling #11661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Jan 15, 2025
apps/gdalwarp_lib.cpp
Outdated
| @@ -2946,6 +2946,30 @@ static GDALDatasetH GDALWarpDirect(const char *pszDest, GDALDatasetH hDstDS, | |||
| psWO->hSrcDS = hWrkSrcDS; | |||
| psWO->hDstDS = hDstDS; | |||
|
|
|||
| if (const char *pszTieStrategy = | |||
There was a problem hiding this comment.
I believe this should be done in GDALWarpOperation::Initialize() and GDALWarpOperation::ValidateOptions(). Otherwise, as it, I don't think that doing "gdalwarp -r mode -wo MODE_TILES=xxxx -of VRT in.tif tmp.vrt" + "gdal_translate tmp.vrt out.tif" is going to work properly
There was a problem hiding this comment.
You're right, it does not work properly. Fixed according to your suggestion
dbaston
force-pushed
the
warp-mode-fixes
branch
from
bf4f0f2 to
b075d49
Compare
|
rasterio/rasterio#3293 to handle a new value for mode in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On top of #11649, renames several variables as suggested in #11649 (comment)
While editing the code, I noticed that
This PR addresses both of these issues.