Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_last_maintenance : filter out small tables #330

Conversation

yhuelf
Copy link
Contributor

@yhuelf yhuelf commented Sep 9, 2022

The idea is to avoid false positives generated by empty or very small tables.

@ioguix
Copy link
Member

ioguix commented Nov 30, 2023

The last_vacuum & last_analyze services are supposed to check if the planned maintenances succeed.

If you don't have planned maintenances, you don't need to check them, you don't need to deploy this service, no matter how large are your tables.

This should probably be documented, so @Krysztophe just did it in PR #366.

However, when studying this issue, we found partitioned tables were raising errors even after being vacuumed. The issue #365 has been created to track this.

@ioguix ioguix closed this Nov 30, 2023
@ioguix
Copy link
Member

ioguix commented Nov 30, 2023

@Krysztophe insist to say:

on empty tables, it doesn't matter to run vacuum because it's almost cost free. So no need to optimize this use case.

@yhuelf
Copy link
Contributor Author

yhuelf commented Jul 4, 2024

Actually, I disagree with you. You can have planned maintenances, but some people have working tables which are created / destroyed regularly. We could avoid the false positives with an --exclude parameter (#369), but filtering out very small tables (with less than 50 tuples) would be beneficial.

(that being said, the default thresholds of this PR are too high)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants