-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated keyword linking script to also update the URI of existing links #482
base: main
Are you sure you want to change the base?
Conversation
THis is quite obfuscated as includes the other PR. Please explain what the changes to the script are. I guess the problem of broken links arises whenever someone uses libreoffice to change a keyword file |
@blattms Yes maybe... another thing is that many of the links may not be broken, but linking to another version of the same keyword. For example, the |
@hakonhagland: can you include the commit from #481 here possibly? Then this check https://github.com/OPM/opm-reference-manual/actions/runs/12757567531/job/35558097602?pr=482 should pass, right? |
ef26576
to
6a5995f
Compare
@lisajulia Yes, I have now included that commit. But now the second check fails. To make this check pass we need to update the URIs for most keywords as noted in #482 (comment). I have started on this process in #483. However, I think this failing check should not prevent this PR from being merged as the purpose of this check will be as an aid for future PRs. |
ok, but then thick check that is failing now will only succeed once all neccessary URIs are updated and merged to master, i.e., when #483 is ready and merged, right? |
Yes, but I guess it will not succeed even after #483 is merged, since that is only for chapter 4, we need to also update links in chapter 5, 6, 7, ... and so on. Which will be done in separate PRs after #483 has been merged |
Ok, how about moving the addition of this file, i.e. the introduction of this new test, to a separate commit and merge this when it's green? Sorry about being so picky, but I'm not a fan of merging things that make the pipeline red 🤔 |
6a5995f
to
2619920
Compare
@lisajulia I have deactivated the second check, so all checks should pass now. |
Updated keyword linking script to also update URI of existings links if needed.
2619920
to
205743e
Compare
Builds on #478, which should be merged first.
Updated keyword linking script to also update the URI of existing links if needed.