Update unhappy path remove-company endpoint POST #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berroar
approved these changes
Dec 19, 2023
katie-gardner
approved these changes
Dec 21, 2023
berroar
deleted the
prevent-duplicate-answer-ids-across-different-list-collectors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
As a result of the bug fix to prevent duplicate
answer_idfrom appearing in different list collectors, thetest_benchmark_business.jsonneeded to be updated. This then meant that the benchmark journey for the unhappy path needed to be updated to pick up the answer_id changeHow to review
Run the unhappy path benchmark locally to ensure that the requests run correctly.
Note: There is an existing issue with the unhappy path benchmark atm around the
GET,/questionnaire/people/{id}/set-min-max-block/end point - this will be addressed in another ticket