Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for invalid html tags #244

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add validation for invalid html tags #244

wants to merge 9 commits into from

Conversation

berroar
Copy link
Contributor

@berroar berroar commented Jun 4, 2024 •
edited
Loading

What is the context of this PR?

Adds validation to identify any invalid HTML in our translatable strings e.g. anything that is not using <strong> or <a>.

How to review

Check that the validation is working as expected

Checklist

  • eq-translations updated to support any new schema keys which need translation

@berroar berroar marked this pull request as ready for review June 4, 2024 11:09
VirajP1002
VirajP1002 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@VirajP1002 VirajP1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works really nicely! Tests pass and changes look good. I also tested the changes in Runner and validation works as intended!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VirajP1002 VirajP1002 VirajP1002 approved these changes

@petechd petechd petechd approved these changes

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berroar @petechd @VirajP1002