Change documentation for legend and legendIsQuestionTitle params #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SriHV
added
the
Documentation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The documentation around the |
rmccar
reviewed
Jan 7, 2025
admilne
approved these changes
Jan 9, 2025
rmccar
changed the title
rmccar
reviewed
Jan 9, 2025
SriHV
changed the title
rmccar
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-205.
Based on the macro file, the
legendandlegendIsQuestionTitleparameters are not mutually exclusive. ThelegendIsQuestionTitleparameter is used to render the legend as an<h1>tag. Many components use only the legend param only, the legendIsQuestionTitle parameter can be false.Changed this in mutually exclusive component where these params are defined
How to review this PR
Check that documentation is updated
Checklist
This needs to be completed by the person raising the PR.