Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_statement_import_online_gocardless: use a hashing strategy to produce the unique_transaction_id #758

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

JordiBForgeFlow
Copy link
Member

@JordiBForgeFlow JordiBForgeFlow commented Jan 3, 2025

When using account_statement_import_online_gocardless with Wise, on a given payment Wise creates two transactions. One for the payment and one for the fee.

Each payment using Wise generates 2 transactions:

  1. Payment transaction: contains a unique transactionID
  2. Fee transaction: contains a unique transactionID, and adds to the field entryReference the transactionID associated with the payment.

So we cannot rely on the field 'entryReference' to construct the 'unique_import_id'.

In general one realizes that it can be very hard to decide which field will contain the unique transaction identifier. So, why not use all possible fields and produce a hash of them all?

This is what this PR does.

@JordiBForgeFlow
Copy link
Member Author

@pedrobaeza @etobella What do you think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant